Skip to content

Added conversion of hostname to IP #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added conversion of hostname to IP #21

wants to merge 4 commits into from

Conversation

gollumben
Copy link

Dear Orca,

thank you very much for this neat piece of code!

I added the support to connect to influxdb using the hostname instead of the IP address.

Cheers,
Ben

@manubrulo
Copy link

Please accept this pull request since I had to add it manually once I cloned the repo without knowing that this was already solved but not added.

@orca-zhang
Copy link
Owner

Dear Ben,

Thanks to your contribution.

The feature helps when put in a hostname instead of IP address.

But inet_ntoa is not thread-safe, inet_ntop maybe better.

And I think new solution should be found to instead std::exit when failed to translate hostname to IP address.

Best Regards,
Orca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gollumben @manubrulo @orca-zhang